Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Claudio W <[email protected]>
  • Loading branch information
flakey5 and ovflowd authored Jan 7, 2025
1 parent 96355ad commit 065ba36
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions bin/cli.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ const parsedApiDocs = await parseApiDocs(apiDocFiles);

const sourceFiles = loadJsFiles(
parsedApiDocs
.map(apiDoc => apiDoc.source_link_local)
.filter(path => path !== undefined && path.endsWith('.js'))
.map(({ source_link_local }) => source_link_local)
.filter(path => path?.endsWith('.js'))
);

const parsedJsFiles = await parseJsSources(sourceFiles);
Expand Down
2 changes: 1 addition & 1 deletion src/generators.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import availableGenerators from './generators/index.mjs';
* @param {ApiDocMetadataEntry} input The parsed API doc metadata entries
* @param {Array<import('acorn').Program>} parsedJsFiles
*/
const createGenerator = (input, parsedJsFiles) => {
const createGenerator = (markdownInput, jsInput) => {
/**
* We store all the registered generators to be processed
* within a Record, so we can access their results at any time whenever needed
Expand Down

0 comments on commit 065ba36

Please sign in to comment.