-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tests for nativeClassProperties #64
Conversation
80190fa
to
d06ced4
Compare
The test case is wrong. The desired outcome is for field initializers to remain as field initializers. I'm guessing the transforms list needs an extra option: |
this is the updated test test("test native class properties", (t) => {
const inputCode = `
class TypeScriptParameterProperties {
initializedField = this.pp;
constructor(public pp: any) {
console.log('finally');
}
}`;
const { code } = transformSync(inputCode, {
mode: "transform",
sourceMap: true,
transform: {
verbatimModuleSyntax: true,
nativeClassProperties: true,
useDefineForClassFields: true,
},
});
console.log(code)
t.assert.snapshot(code);
}); output:
@robpalme is it correct? |
The test output is incorrect. So we're not picking up the desired new behavior yet. |
The current module relationship is Now, the We may need @kdy1 to explain the compilation and update process. |
@magic-akari do you know if today's |
I don't know. There are methods to ensure the use of a local build over crate packages. For details, refer to the script in this CI I'm not certain if this is the recommended method. |
maybe @kdy1 knows? |
Sorry, I missed the email. I'll publish |
I published those crates and triggered publish of |
thank you! |
No description provided.