Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update SWC to v1.10.3 #139

Merged
merged 4 commits into from
Dec 29, 2024
Merged

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Dec 29, 2024

Fixes: #125
This PR updates SWC to v1.10.3.
View the SWC changelog for more information.

@marco-ippolito
Copy link
Member

marco-ippolito commented Dec 29, 2024

@kdy1 unfortunately the issue with the semicolon seems to remain.

Acutally this time is different 🤔

Before it used to be:

"using r = 0\\n;\\n"

Now:

"using r = 0;\\n"

I think now its the correct behavior.
It means there was already a bug before 1.10.2
See: 884c2c9

@marco-ippolito marco-ippolito merged commit a6caebe into main Dec 29, 2024
11 checks passed
@marco-ippolito marco-ippolito deleted the chore/update-swc-1.10.3 branch December 29, 2024 10:10
@robpalme
Copy link

This PR improves the using cases by eliminating one of the two suffix newlines that SWC previously injected. So it looks good to merge.


Separately, all the transform test snapshots have a \n suffix that seems redundant and is not present in the (type-stripping) non-transform tests. But that is a pre-existing condition, not caused by this PR. So I raised #140 to discuss that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust audit fail
3 participants