test: ensure loaders passes for non ts #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturgawlik
changed the title
marco-ippolito
approved these changes
Dec 15, 2024
|
it's just matter of configuring it |
arturgawlik
force-pushed
the
ensure-loaders-passes-for-non-ts
branch
from
ea46fdc to
14c3521
Compare
marco-ippolito
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 😊 I was looking into tests code coverage and it seems that for non typescript files we're not ensuring that
nextLoadis called, there:amaro/src/strip-loader.ts
Line 35 in 2ebb063
amaro/src/transform-loader.ts
Line 43 in 2ebb063
This PR adds tests that checks that, but if You think that it is something that is not worth to test please let me know so I will close this PR.
Also wondering: is there any reason why test coverage for amaro is not configured here https://app.codecov.io/gh/nodejs? or it's just luck of time/resources?