bug fixed #53 #54
bug fixed #53 #54
Conversation
public/script.js
Outdated
| } | ||
| } | ||
| else { | ||
| console.error(JSON.parse(xhr.responseText)); |
There was a problem hiding this comment.
Another bug :) responseText here is a normal string - not stringified JSON - so it breaks when you try to parse it.
The reason why we need to parse on line 7 is because in that case we're sending back the JSON of our blogposts. Here though, it's just a regular string!
There was a problem hiding this comment.
I recommend you test this out in your own code when making this change, so you can see what I mean. For example, you could change the endpoint to something that doesn't exist, then you can see what happens when there's an error.
Maybe we should close this PR and @minaorangina you could put the same review in #53 so that we have a record of everything in the same place? @Salam-Dalloul as Mina said, you can just push to the same branch, so if you have a look at your other pull request, you can see your new changes are now in there! 😃 |
|
@minaorangina all fixed ... hopefully nothing is messing |
There was a problem hiding this comment.
Looks good to me @Salam-Dalloul, thanks very much! Feel free to merge 🎉
|
Thanks @minaorangina 😄
and i'm not a collaborator 😸 |
Relates: #53
@claireinez @minaorangina @msmichellegar for review.
In Referance to : Curriculum planning - SPRING 2018 https://github.com/foundersandcoders/master-reference/issues/781