feat(password): add password input glyph animation eye candy like V4#3239
Open
mattvilim wants to merge 1 commit into
Open
feat(password): add password input glyph animation eye candy like V4#3239mattvilim wants to merge 1 commit into
mattvilim wants to merge 1 commit into
Conversation
83a5f9e to
d064ab9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an animation when typing passwords similar to what V4 had. This applies to lock screen, polkit panel, and WiFi password. It animates both "random" glyphs and circular ones. See video below for example.
I designed the animation based on my vague memory of what V4 looked like. 😄
Motivation
Make Noctalia even more dank than DMS.
Type of Change
Related Issue
N/A
Testing
See video below. I tested with
shell.password_stylerandomanddefaulton lock screen and polkit. I also checkedshell.animation.enabled= false doesn't break anything.Manual Coverage
Screenshots / Videos
recording_20260701_150906.mp4
Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installed, or this PR has no code changes.assets/translations/en.json, or this PR adds no new user-facing strings.Additional Notes
I left a note in the PR about render pixel snapping related to the scale animation. The current solution works to avoid snapping mid-animation. Using animation-aware render snapping might make more sense than the stateless matrix transform heuristics in the future. I'd have to think about it more...