feat: by_item for Python API#128
Open
flying-sheep wants to merge 1 commit intonnethercott:mainfrom
Open
Conversation
flying-sheep
commented
Apr 20, 2026
|
|
||
|
|
||
| macro_rules! hnsw_search { | ||
| ($reader:expr, |r| r . $($q:tt)*) => { |
Author
There was a problem hiding this comment.
this is pretty fragile towards code changes, but it’s just an internal macro, so it can be extended as needed.
flying-sheep
commented
Apr 20, 2026
Comment on lines
+42
to
+43
| pyo3 = { version = "0.26.0", optional = true } | ||
| pyo3-stub-gen = { version = "0.22.1", optional = true } |
Author
There was a problem hiding this comment.
updated pyo3-stub-gen for __all__ and some other improvements.
pyo3 0.26 is at this point also pretty established so that bump shouldn’t be a problem.
Author
|
@nnethercott ping |
Owner
|
@flying-sheep thanks for tackling this ! fun fact: I based the original bindings off what you'd done on |
Author
|
Haha I assumed so! Happy to help out with more, the Python bindings are a bit minimal at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’m also getting rid of some invalid metadata (
build-systemhas only 2 valid subkeys) and obsolete syntax (typing.List)Addresses part of #127, but not yet the batch APIs