Fix setuptools.distutils import for Python 3.12+#646
Open
EmilienM wants to merge 1 commit intonmslib:masterfrom
Open
Fix setuptools.distutils import for Python 3.12+#646EmilienM wants to merge 1 commit intonmslib:masterfrom
EmilienM wants to merge 1 commit intonmslib:masterfrom
Conversation
The setuptools.distutils.errors.CompileError import path is broken on Python 3.12+ where setuptools no longer exposes the distutils subpackage at the old path. Replace with a broad Exception catch which handles CompileError regardless of setuptools version. Signed-off-by: Emilien Macchi <emacchi@redhat.com>
Author
|
@dyashuni @yurymalkov please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setuptools.distutils.errors.CompileError import path is broken on
Python 3.12+ where setuptools no longer exposes the distutils subpackage
at the old path. Replace with a broad Exception catch which handles
CompileError regardless of setuptools version.
Signed-off-by: Emilien Macchi emacchi@redhat.com