Skip to content

Fix field type validation – propagate result of validation #2914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

Fix field type validation – propagate result of validation #2914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/MigrationTools.Clients.TfsObjectModel/Tools/TfsWorkItemTypeValidatorTool.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ private bool ValidateWorkItemTypeFields(WorkItemType sourceWit, WorkItemType tar
}
else
{
ValidateField(sourceField, targetFields[targetFieldName], targetWit.Name);
result &= ValidateField(sourceField, targetFields[targetFieldName], targetWit.Name);
}
}
else
Expand All @@ -135,7 +135,7 @@ private bool ValidateWorkItemTypeFields(WorkItemType sourceWit, WorkItemType tar
return result;
}

private void ValidateField(FieldDefinition sourceField, FieldDefinition targetField, string targetWitName)
private bool ValidateField(FieldDefinition sourceField, FieldDefinition targetField, string targetWitName)
{
// If target field is in 'FixedTargetFields' list, it means, that user resolved this filed somehow.
// For example by value mapping. So any discrepancies found will be logged just as information.
Expand All @@ -156,6 +156,7 @@ private void ValidateField(FieldDefinition sourceField, FieldDefinition targetFi
+ $" because it is listed in '{nameof(Options.FixedTargetFields)}'.",
targetField.ReferenceName, targetWitName, sourceField.ReferenceName);
}
return (logLevel == LogLevel.Information) || isValid;
}

private bool ValidateFieldType(FieldDefinition sourceField, FieldDefinition targetField, LogLevel logLevel)
Expand Down
Loading