Refactor user group name handling in TfsUserMappingTool #2906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced hardcoded "Project Collection Valid Users" string in `TfsUserMappingTool.cs` with a configurable property `Options.ProjectCollectionValidUsersGroupName`. Added this property to `TfsUserMappingToolOptions.cs` to allow customization of the group name, with a default value of "Project Collection Valid Users".
2 tasks
…usermappingtoolgetuserslistfromserver
Updated TfsUserMappingTool configuration to include a new parameter, `ProjectCollectionValidUsersGroupName`, in the YAML and JSON schema files. Clarified documentation for `MatchUsersByEmail` while keeping its functionality unchanged. These changes enhance the tool's ability to reference the valid users group during user mapping processes.
2 tasks
2 tasks
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-river-093197403-2906.westeurope.5.azurestaticapps.net |
MrHinsh
deleted the
2895-bug-systemnullreferenceexception-in-tfsusermappingtoolgetuserslistfromserver
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced hardcoded "Project Collection Valid Users" string in
TfsUserMappingTool.cswith a configurable propertyOptions.ProjectCollectionValidUsersGroupName. Added this property toTfsUserMappingToolOptions.csto allow customization of the group name, with a default value of "Project Collection Valid Users".Fixes: #2895
Co-authored-by: sl-io [email protected]