Open
Conversation
Implement core MQTT 5.0 features including property encoding/decoding, reason codes, and updated packet formats. Default protocol version changed from 3.1.1 to 5.0. Core features: - Variable-length integer encoding for properties - Property support for all packet types (Connect, Connack, Publish, Subscribe, Unsubscribe, Disconnect, and ACK packets) - Reason codes replacing simple return codes - Session expiry interval, message expiry interval, user properties Backward compatible: existing 3.1.x code works by setting version. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When receiving packets from a broker, the version was not being passed to Packet.read(), causing MQTT 5.0 properties to not be parsed. This resulted in the properties length byte being left in the payload. Changes: - Add version parameter to MQTT::Packet.read() - Pass @Version from client when reading packets - Update receive_packet tests to use explicit version 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
hakehuang
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Core Features Added
Backward Compatibility
version: '3.1.1'Test plan
🤖 Generated with Claude Code