Check exit code in Dir::as_raw_fd#2747
Open
stepancheg wants to merge 1 commit intonix-rust:masterfrom
Open
Conversation
stepancheg
force-pushed
the
dir-panic
branch
from
35d63ac to
2698f47
Compare
stepancheg
force-pushed
the
dir-panic
branch
from
2698f47 to
1ac1cb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
libc::dirfdshould not fail. But if does, we better do some error detection (panic) rather than quietly returning incorrect value.Alternatively we can stop implementing
AsRawFd.Checklist:
CONTRIBUTING.md