fix: make nix build on Illumos #2694
Merged
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
|
Let me add a changelog for this PR |
extrowerk
force-pushed
the
illumos_patches
branch
from
4d7ba5c to
1d8cb28
Compare
SteveLauC
force-pushed
the
illumos_patches
branch
from
1d8cb28 to
3ffba6e
Compare
Looks like Solaris does not have them according to our CI [1] [1]: https://github.com/nix-rust/nix/actions/runs/19349070659/job/55356544189?pr=2694
Member
|
Hi @extrowerk, looks like module I guess it should still work, but it would be still great if you could give this patch a re-check by either compiling nix or the fish shell on an Illumos machine. |
Member
|
Emm, I forgot that auto-emrge was still enabled when I left my last comment:D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
This changes lets nix build and work on Illumos based operating systems. Tested on OpenIndiana and OmniOS.
Checklist:
CONTRIBUTING.md