ci: bump remaining Ubuntu 20.04 to latest version#2533
Open
SteveLauC wants to merge 1 commit intonix-rust:masterfrom
Open
ci: bump remaining Ubuntu 20.04 to latest version#2533SteveLauC wants to merge 1 commit intonix-rust:masterfrom
SteveLauC wants to merge 1 commit intonix-rust:masterfrom
Conversation
3 tasks
asomers
approved these changes
Nov 11, 2024
tisonkun
reviewed
Jan 29, 2025
| # would fail on 22.04 and 24.04 (at least for now) | ||
| # https://github.com/nix-rust/nix/issues/2418 | ||
| runs-on: ubuntu-20.04 | ||
| runs-on: ubuntu-latest |
Contributor
There was a problem hiding this comment.
Suggested change
| runs-on: ubuntu-latest | |
| runs-on: ubuntu-22.04 |
Generally pin a version is more stable. We can upgrade 24.04 when it's ready, but never accidently broken by a GitHub change.
Member
Author
There was a problem hiding this comment.
Makes sense, I will do a cleanup of this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
Due to the requirement of #2525 (comment), try bumping the remaining Ubuntu 20.04 images to the latest version, if we are lucky, closes #2418.
Checklist:
CONTRIBUTING.md