-
Notifications
You must be signed in to change notification settings - Fork 713
Fix: build target wasm32-unknown-emscripten #2477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: build target wasm32-unknown-emscripten #2477
Conversation
CI fixed in #2478, please rebase your branch:) |
248e76c
to
c0a1c96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing it for Nix, just one tiny issue:)
BTW, perhaps we can have a changelog for this, please see CONTRIBUTING.md on how to add one, something like this would suffice:
Add the support for Emscripten. |
c0a1c96
to
6723feb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Ahh, our Cirrus CI has been quite unstable recently... |
Damn it, I think our Cirrus CI is broken, which is definitely not related to this PR, I will take a look later:< |
Weird, Cirrus CI works fine in other PRs, let's merge this PR anyway! |
What does this PR do
Fix failed to build for target
wasm32-unknown-emscripten
with this error:To pass the build, I made the following changes:
errno::errno_location
function for Emscripten.errno::consts
module as Linux.Checklist:
CONTRIBUTING.md