lorri: add darwin launchd support #8186
Open
+145
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a darwin daemon for lorri
isomarcte
force-pushed
the
darwin-lorri
branch
from
38d57f5 to
b3a1995
Compare
Contributor
Author
|
@Gerschtli @nyarly anything I can do to move this along? |
Contributor
Sorry - it's been holiday weeks around here. Lemme look... |
nyarly
approved these changes
Dec 1, 2025
Contributor
nyarly
left a comment
nyarly
left a comment
There was a problem hiding this comment.
I can't test this on Darwin, but it looks good to me.
khaneliman
reviewed
Dec 3, 2025
Comment on lines
+50
to
+56
| warnings = | ||
| if cfg.enableNotifications then | ||
| [ | ||
| "services.lorri.enableNotifications is not currently supported for Darwin." | ||
| ] | ||
| else | ||
| [ ]; |
Collaborator
There was a problem hiding this comment.
Could probably make it not visible and read-only on darwin, as well.
khaneliman
reviewed
Dec 3, 2025
Comment on lines
-35
to
-37
| assertions = [ | ||
| (lib.hm.assertions.assertPlatform "services.lorri" pkgs lib.platforms.linux) | ||
| ]; |
Collaborator
There was a problem hiding this comment.
If we're removing the platform limitation, it would be nice to create a news entry and update the test suite to test on darwin, as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a Darwin daemon for lorri
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like