Skip to content

refactor: accept an invitation in one request - #345

Merged
davemooreuws merged 1 commit into
mainfrom
accept-invite-once
Oct 9, 2026
Merged

davemooreuws merged 1 commit into
mainfrom
accept-invite-once

Conversation

@davemooreuws

@davemooreuws davemooreuws commented Oct 8, 2026 •

Copy link
Copy Markdown
Member
  • The invitation lookup returns either pending or accepted (with the workspace id). The invite page goes straight into the workspace for an accepted one, instead of calling complete-invite on every load to find out.
  • Accepting again returns the same workspace. Someone no longer in the workspace gets "not found", so an old link can't be used to rejoin.
  • The model choice moves from complete-invite into Membership.accept unchanged: the workspace's default model, or the first offered while the default isn't offered.
  • Accepting now lands in the workspace joined. The invite page refetches the workspace list before leaving, so / finds it instead of falling back to the person's first workspace.
  • / skips the chosen workspace only when opening it would send the person into its setup, so someone invited to a workspace whose setup isn't finished lands in it rather than in their own.

Closes SUGA-1982

@davemooreuws
davemooreuws added this pull request to stack #346 October 8, 2026 05:33
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
sugabots-website 4ef3cca Oct 09 2026, 02:18 AM

@davemooreuws
davemooreuws force-pushed the accept-invite-once branch 2 times, most recently from 732f4e4 to cc9940d Compare October 8, 2026 22:10
Base automatically changed from drop-onboarding-flag to main October 9, 2026 01:40
@davemooreuws
davemooreuws merged commit 64ed3dc into main Oct 9, 2026
7 checks passed
@davemooreuws
davemooreuws deleted the accept-invite-once branch October 9, 2026 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant