Skip to content

allow sequence types for fields with requires (can be empty) #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tclose
Copy link
Contributor

@tclose tclose commented May 20, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Summary

Allows task fields of Sequence type to have non-empty requires (as they can be empty if requirements are not met)

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.89%. Comparing base (47c3958) to head (3af9d53).

Files with missing lines Patch % Lines
pydra/compose/base/field.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #827   +/-   ##
=======================================
  Coverage   87.89%   87.89%           
=======================================
  Files          84       84           
  Lines       17890    17890           
  Branches     3483     3483           
=======================================
  Hits        15725    15725           
  Misses       1809     1809           
  Partials      356      356           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tclose tclose force-pushed the sequence-requires-validator branch from 28801a2 to 3af9d53 Compare June 21, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant