Skip to content

FIX: Inconsistent flips of ITK's displacements fields - including loading from h5 #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

oesteban
Copy link
Collaborator

Summary

  • verify that points mapped through a composite HDF5 transform agree with antsApplyTransformsToPoints

Testing

  • pytest nitransforms/tests/test_io.py::test_composite_h5_map_against_ants -q

https://chatgpt.com/codex/tasks/task_e_68808465c5e08330a6e9cbb469021814

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (0ae771d) to head (e48e2c4).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
nitransforms/io/itk.py 0.00% 7 Missing ⚠️
nitransforms/nonlinear.py 0.00% 2 Missing ⚠️
nitransforms/resampling.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0ae771d) and HEAD (e48e2c4). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (0ae771d) HEAD (e48e2c4)
7 1
unittests 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #264       +/-   ##
==========================================
- Coverage   95.09%   0.00%   -95.10%     
==========================================
  Files          16      16               
  Lines        1979    1973        -6     
  Branches      265       0      -265     
==========================================
- Hits         1882       0     -1882     
- Misses         77    1973     +1896     
+ Partials       20       0       -20     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oesteban oesteban force-pushed the codex/add-test-case-for-composite-h5-transform branch from 43a0a04 to 45745bd Compare July 23, 2025 17:16
@oesteban oesteban changed the title Add composite H5 mapping test against ANTs FIX: Inconsistent flips of ITK's displacements fields - including loading from h5 Jul 23, 2025
@oesteban oesteban force-pushed the codex/add-test-case-for-composite-h5-transform branch 2 times, most recently from 691fd0b to 51044f6 Compare July 23, 2025 20:22
@oesteban oesteban force-pushed the codex/add-test-case-for-composite-h5-transform branch from 51044f6 to 58b4b23 Compare July 23, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant