[ENH]bedpostx and probtrackx gpu and multithread support#3722
Open
mauriliogenovese wants to merge 3 commits intonipy:masterfrom
Open
[ENH]bedpostx and probtrackx gpu and multithread support#3722mauriliogenovese wants to merge 3 commits intonipy:masterfrom
mauriliogenovese wants to merge 3 commits intonipy:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3722 +/- ##
==========================================
+ Coverage 72.85% 72.88% +0.03%
==========================================
Files 1279 1279
Lines 59321 59387 +66
==========================================
+ Hits 43219 43287 +68
+ Misses 16102 16100 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8f89cdc to
ebe842d
Compare
ebe842d to
0c86c0b
Compare
effigies
reviewed
Mar 2, 2026
Comment on lines
+1091
to
+1092
| super().__init__(**inputs) | ||
| self.inputs.on_trait_change(self._cuda_update, "use_gpu") |
Member
There was a problem hiding this comment.
IIUC, this will only trigger _cuda_update if use_gpu is set after the interface is initialized, and not respect the parameter in ProbTrackX2(..., use_gpu=True).
What about:
Suggested change
| super().__init__(**inputs) | |
| self.inputs.on_trait_change(self._cuda_update, "use_gpu") | |
| super().__init__(**inputs) | |
| self.inputs.on_trait_change(self._cuda_update, "use_gpu") | |
| self._cuda_update() |
Comment on lines
456
to
+457
| self.inputs.on_trait_change(self._cuda_update, "use_gpu") | ||
| self.inputs.on_trait_change(self._num_threads_update, "num_threads") |
Member
There was a problem hiding this comment.
Likewise, does this work if I pass use_gpu or num_threads to __init__()? Or should you call these unconditionally here?
…riliogenovese/nipype into fix-fsl-dti-parallel-and-gpu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will enable the gpu version of probtrackx2 and add support to specify the number of thread used by bedpostx (by default it uses a thread per available core)