fixes #25346; compare the last sons of tyGenericInst #25378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Dec 20, 2025
compiler/types.nim
Outdated
| for ff, aa in underspecifiedPairs(rhs, lhs, 1, -1): | ||
| if not sameTypeAux(ff, aa, c): return false | ||
| return true | ||
| return sameTypeAux(lhs.skipModifier, rhs.skipModifier, c) |
Member
There was a problem hiding this comment.
But we know here that the bases are the same as well es their pairs. So what does this really do? Rewrite it so that it is obvious, instead of yet another recursive call that god knows what is doing...
demotomohiro
force-pushed
the
fixes-25346
branch
from
512a89e to
85207a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.