Lbcheng #25225
Open
Lbcheng #25225
+775
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arc/orc Add ARC/ORC regression for async callSoon closures
…eration changes (nimTraceClosure, mandatory attachedTrace),
runtime support (TNimTypeV2, cyclebreaker.releaseGraph/thinout, lightweight nimTraceRef* stub), and async lifecycle fixes
(callSoon, consolidated leak tests, new stress suites).
- Published the verification matrix that was used to vet the new behavior (ARC/ORC runs, threaded scenarios, leak counters).
|
Most interesting. Can you give us more documentation please? |
added 3 commits
October 17, 2025 08:31
|
sure, b395500 |
Araq
reviewed
Oct 17, 2025
lib/system/orc.nim
Outdated
|
|
||
| proc unregisterCycle(s: Cell) = | ||
| # swap with the last element. O(1) | ||
| if s.rootIdx == 0: |
There was a problem hiding this comment.
Seems fishy. Why can this happen now that we support thinOut?
There was a problem hiding this comment.
Thanks for reviewing and comment.
There was a problem hiding this comment.
thinOut only guarantees that the roots array is compact at the moment it runs.
During destructors or partial collections roots can be mutated again and the
cached rootIdx becomes stale (it can even drop to zero although the entry is
still present). With thinOut alone we can still reach unregisterCycle with an
invalid index. The fix recompacts roots on demand and rescans for the cell so
the removal is always correct.
added 2 commits
October 17, 2025 16:25
Destructors and partial collects can reshuffle the ORC roots array, leaving
entries with rootIdx <= 0 even though the cell remains tracked. The old
unregisterCycle treated that as already-unlinked and leaked the root.
Add an internal compactRoots helper that recomputes indices, let
unregisterCycle revalidate its slot (falling back to a scan if thin-out moved
the cell), and only then swap it with the tail.
Tests: testament/testament --nim:bin/nim c arc "--mm:arc"
testament/testament --nim:bin/nim c arc "--mm:orc"
nim c --gc:orc -d:nimThinout -r tests/arc/thamming_thinout.nim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime support (TNimTypeV2, cyclebreaker.releaseGraph/thinout, lightweight nimTraceRef* stub), and async lifecycle fixes
(callSoon, consolidated leak tests, new stress suites).