fixes #25048; Closure environment wrongly marked as cyclic #25220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
narimiran
pushed a commit
that referenced
this pull request
Oct 15, 2025
fixes #25048 ```nim proc canFormAcycleAux = of tyObject: # Inheritance can introduce cyclic types, however this is not relevant # as the type that is passed to 'new' is statically known! # er but we use it also for the write barrier ... if tfFinal notin t.flags: # damn inheritance may introduce cycles: result = true ``` It seems that all objects without `tfFinal` in their flags are registering cycles. It doesn't seem that `Env` can be a cyclic type because of inheritance since it is not going to be inherited after all by another `Env` object type (cherry picked from commit f191ba8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #25048
It seems that all objects without
tfFinalin their flags are registering cycles. It doesn't seem thatEnvcan be a cyclic type because of inheritance since it is not going to be inherited after all by anotherEnvobject type