Dropping HHVM support

nilportugues · Feb 10, 2017 · 57464fa · 57464fa
1 parent f55a6c7
commit 57464fa
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 50 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -2,18 +2,14 @@ language: php
 php:
   - "5.6"
   - "7.0"
-  - "hhvm"
+  - "7.1"
 
 before_script:
   - composer install
-
 
 script: 
   - bin/phpunit --coverage-text
 
-matrix:
-     allow_failures:
-         - php: "hhvm"
 branches:
   only:
     - master

diff --git a/src/Mapping/serialization_hhvm.php b/src/Mapping/serialization_hhvm.php
diff --git a/src/Mapping/unserialization_hhvm.php b/src/Mapping/unserialization_hhvm.php
diff --git a/src/Serializer.php b/src/Serializer.php
@@ -62,11 +62,6 @@ class Serializer
         'string' => 'serializeScalar',
     ];
 
-    /**
-     * @var bool
-     */
-    protected $isHHVM;
-
     /**
      * Hack specific serialization classes.
      *
@@ -79,16 +74,7 @@ class Serializer
      */
     public function __construct(StrategyInterface $strategy)
     {
-        $this->isHHVM = \defined('HHVM_VERSION');
-        if ($this->isHHVM) {
-            // @codeCoverageIgnoreStart
-            $this->serializationMap = \array_merge(
-                $this->serializationMap,
-                include \realpath(\dirname(__FILE__).'/Mapping/serialization_hhvm.php')
-            );
-            $this->unserializationMapHHVM = include \realpath(\dirname(__FILE__).'/Mapping/unserialization_hhvm.php');
-            // @codeCoverageIgnoreEnd
-        }
+
         $this->serializationStrategy = $strategy;
     }
 
@@ -142,12 +128,6 @@ protected function serializeData($value)
     {
         $this->guardForUnsupportedValues($value);
 
-        if ($this->isHHVM && ($value instanceof \DateTimeZone || $value instanceof \DateInterval)) {
-            // @codeCoverageIgnoreStart
-            return \call_user_func_array($this->serializationMap[get_class($value)], [$this, $value]);
-            // @codeCoverageIgnoreEnd
-        }
-
         if ($this->isInstanceOf($value, 'SplFixedArray')) {
             return SplFixedArraySerializer::serialize($this, $value);
         }
@@ -313,15 +293,6 @@ protected function unserializeDateTimeFamilyObject(array $value, $className)
         $obj = null;
 
         if ($this->isDateTimeFamilyObject($className)) {
-            if ($this->isHHVM) {
-                // @codeCoverageIgnoreStart
-                return \call_user_func_array(
-                    $this->unserializationMapHHVM[$className],
-                    [$this, $className, $value]
-                );
-                // @codeCoverageIgnoreEnd
-            }
-
             $obj = $this->restoreUsingUnserialize($className, $value);
             self::$objectMapping[self::$objectMappingIndex++] = $obj;
         }