feat: handles object-fit of img and video element#3218
Open
mmis1000 wants to merge 1 commit intoniklasvh:masterfrom
Open
feat: handles object-fit of img and video element#3218mmis1000 wants to merge 1 commit intoniklasvh:masterfrom
mmis1000 wants to merge 1 commit intoniklasvh:masterfrom
Conversation
mmis1000
force-pushed
the
feat/video-img-object-fit
branch
from
bf0bf66 to
c4c9be2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes/implements the following bugs/features
Explain the motivation for making this change. What existing problem does the pull request solve?
My app use object-fit a lot and don't work well with html2canvas
Test plan (required)
I changed reftest of image and video element to include element with object-fit set
Code formatting
Please make sure that code adheres to the project code formatting. Running
npm run formatwill automatically format your code correctly.Closing issues
Fixes #3072, the codes are mostly copied from this issue