Set the document clone iframe container's size via the style attribute#3097
Open
15joeybloom wants to merge 1 commit intoniklasvh:masterfrom
Open
Set the document clone iframe container's size via the style attribute#309715joeybloom wants to merge 1 commit intoniklasvh:masterfrom
15joeybloom wants to merge 1 commit intoniklasvh:masterfrom
Conversation
This prevents CSS rules from overriding the iframe's size which would compromise the screenshot
Author
|
For anyone else who might have come across this issue - a good workaround is to use the onclone callback: |
|
Can be tested in |
nangelina
added a commit
to artificialonlinesao/html2canvas
that referenced
this pull request
Feb 9, 2024
Squashed commit of the following: commit d2d83ad Author: Joey Bloom <15joeybloom@gmail.com> Date: Tue Jul 25 16:34:13 2023 -0500 Set the document clone iframe container's size via the style attribute This prevents CSS rules from overriding the iframe's size which would compromise the screenshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes/implements the following bugs/features
Some sites I used html2canvas on have a CSS rule like
This CSS rule takes precedence over the the width and height attributes of the html2canvas iframe container. As a result, the document clone is rendered with a width and height of 0, so I get a blank, all-white screenshot.
This PR also sets the width and height of the iframe within the style attribute. The style attribute will take precedence over any CSS rules.
Test plan (required)
When I tried to run
npm testlocally I got this error:I'm on macos Ventura 13.4.1 using npm 6.12.1 and node v12.13.1