Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grep issue in avd creation #71

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

itsspriyansh
Copy link
Contributor

Issue:

grep command doesn't come pre-installed in windows and therefore its use in scripts might cause problems.

PR accomplishments:

  1. Removed the usage of grep command from the avd creation script where it was used to filter device profiles based on the device type.
  2. New filtering logic is added.

@itsspriyansh itsspriyansh changed the title fix: grep issue in avd creation fix: grep issue in avd creation Dec 10, 2024
@garg3133 garg3133 merged commit 675cdc4 into nightwatchjs:main Dec 15, 2024
2 checks passed
@garg3133
Copy link
Member

Merged! Thanks a lot, @itsspriyansh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants