Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TDD check #36

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Fix TDD check #36

merged 1 commit into from
Dec 26, 2024

Conversation

mountrcg
Copy link
Contributor

Sorry in PR #31 I did not check on Simon's last addition on the weighted average check. The change was supposed to be from:

if (weightPercentage < 1 && weightedAverage > 0) {

to

if (weightPercentage < 1 && weightedAverage > 1) {

@mountrcg mountrcg changed the base branch from dev to tcd December 26, 2024 21:48
@dnzxy dnzxy merged commit 2f258b2 into nightscout:tcd Dec 26, 2024
2 checks passed
@simonp22
Copy link

simonp22 commented Jan 9, 2025

Apologies @mountrcg, It's why I was questioning that change so much!

@mountrcg mountrcg deleted the fixTDDcheck branch January 10, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants