Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update OmniXXX: Fix for pump manager returns bogus podSuspended #469

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

update OmniXXX: Fix for pump manager returns bogus podSuspended #469

wants to merge 1 commit into from
+2 −2

Conversation

marionbarker
Copy link
Contributor

Bring in improvements to OmniBLE and OmniKit.

  • No longer returns a podSuspended message unless the last message received from the pod indicates the pod is actually suspended (fixes a guard logic error)
  • Adds new function, tryToValidateComms, that attempts to update the pod status if communication can be established

This PR brings in submodule changes only and was tested prior to updating the submodules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnzxy dnzxy Awaiting requested review from dnzxy dnzxy is a code owner

@bjornoleh bjornoleh Awaiting requested review from bjornoleh bjornoleh is a code owner

@MikePlante1 MikePlante1 Awaiting requested review from MikePlante1 MikePlante1 is a code owner

@aug0211 aug0211 Awaiting requested review from aug0211 aug0211 is a code owner

@AndreasStokholm AndreasStokholm Awaiting requested review from AndreasStokholm AndreasStokholm is a code owner

@Sjoerd-Bo3 Sjoerd-Bo3 Awaiting requested review from Sjoerd-Bo3 Sjoerd-Bo3 is a code owner

@t1dude t1dude Awaiting requested review from t1dude t1dude is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marionbarker