Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wear: add Loop States tile #3725

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

tdrkDev
Copy link
Contributor

@tdrkDev tdrkDev commented Jan 9, 2025

Provides ability to change loop state (switch modes, disconnect/reconnect pump, suspend/resume loop) from WearOS tile.

I find this tile useful in my usage scenario when I put my watch on charge before going to shower. This tile helps to set "pump disconnected" loop mode directly from my watch instead of finding my phone in the room, opening AAPS, loop dialog and only then disconnecting pump.

The implementation has timestamp-based authorisation, so user can't do something unexpected when tile and DataHandlerMobile go out of sync, also all actions have additional confirmation on watch before actually running.

Copy link

sonarqubecloud bot commented Jan 9, 2025

@MilosKozak
Copy link
Contributor

anyone tested?

@olorinmaia
Copy link
Contributor

olorinmaia commented Jan 11, 2025

Will test it now. @MilosKozak can it be merged with translations for e.g. Russian language or does it need to be done via Crowdin and only provide english strings in PR?

@olorinmaia
Copy link
Contributor

Tested OK for AAPS. Will check how it looks for AAPSClient

<string name="wear_action_loop_state_changed_with_duration">%1$s\nDuration: %2$d min</string>

<string name="wear_action_loop_state_now_closed">Closed</string>
<string name="wear_action_loop_state_now_lgs">LGS</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's plenty of space for text in the wear tile confirmation box I would use Low glucose suspend instead of LGS

@olorinmaia
Copy link
Contributor

olorinmaia commented Jan 11, 2025

Tested OK for AAPSClient, it's like with Automation user action tile, "No configuration", so it can't be used.

Both User action and Loop state is visible for AAPSClient wear, I'm not sure if it's possible to hide them, but that is something that can be improved upon later also.

This is very useful for us when e.g. going to swimming pool, we always disconnect pump, now we don't need to open AAPS phone! Thumbs up from me! :)

@olorinmaia olorinmaia mentioned this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants