Skip to content

Commit

Permalink
🔨 Add explicitly REGISTRY_URL in the ci goal
Browse files Browse the repository at this point in the history
  • Loading branch information
Borie, Niels committed Mar 6, 2024
1 parent 9b01d87 commit 468afb7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_and_publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@ jobs:
if [ "${{ github.ref }}" != 'refs/heads/main' ] && [ "${{ github.ref }}" != 'refs/heads/develop' ]; then
SUPPORTED_PYTHON_VERSIONS="3.9 3.12"
fi
make build-and-push-all-images
make build-and-push-all-images REGISTRY_URL=nielsborie
- name: 🎉 Image digest
run: echo ${{ steps.docker_build.outputs.digest }}
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ build-and-push-all-images: ## Build all machine-learning-environments docker ima
@for version in $(SUPPORTED_PYTHON_VERSIONS); do \
for builder in $(ALL_BUILDERS); do \
for layer in $(ALL_LAYERS); do \
$(MAKE) build-image PYTHON_VERSION=$$version LAYER=$$layer BUILDER=$$builder IMAGE_VERSION=$(IMAGE_VERSION); \
$(MAKE) build-image REGISTRY_URL=$(REGISTRY_URL) PYTHON_VERSION=$$version LAYER=$$layer BUILDER=$$builder IMAGE_VERSION=$(IMAGE_VERSION); \
if [ "$(BRANCH_NAME)" = "develop" ] || [ "$(BRANCH_NAME)" = "main" ]; then \
$(MAKE) push-image PYTHON_VERSION=$$version LAYER=$$layer BUILDER=$$builder IMAGE_VERSION=$(IMAGE_VERSION); \
$(MAKE) push-image REGISTRY_URL=$(REGISTRY_URL) PYTHON_VERSION=$$version LAYER=$$layer BUILDER=$$builder IMAGE_VERSION=$(IMAGE_VERSION); \
fi \
done; \
$(MAKE) clean-images; \
Expand Down

0 comments on commit 468afb7

Please sign in to comment.