Guard concurrent blocking asks#48
Open
davidmoshal wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #47.
This is the minimal fallback fix for concurrent blocking
intercom({ action: "ask" })calls. It preserves the current single-flight behavior, but turns a competing concurrent ask into a structured busy tool error instead of allowingAlready waiting for a replyto terminate Pi.Validation:
askcrash safety.npm testlocally: 38 passing tests.This PR is an alternative to the keyed reply waiter approach; the maintainer should choose one direction rather than merging both as independent fixes.