Fix concurrent intercom reply waiters#33
Open
danrom85 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash/race condition when multiple reply-waiting intercom calls run concurrently.
Previously,
pi-intercomused a single module-scopedreplyWaiter. If twoask/ supervisor-style calls were active at the same time, the second waiter could hitAlready waiting for a reply. In Node versions where unhandled rejections are thrown, this canterminate the Pi process.
This PR changes reply waiting to support independent concurrent waiters keyed by
replyTo/ question ID.Changes
replyWaiterwith aMap<string, ReplyWaiter>replyTo, allowing concurrent asks to coexist.catch(() => undefined)for ask-path reply promises to avoid unhandled rejection crashesValidation
npm installnpm test