Prevent intercom ask reply waiter race#30
Draft
johnpippett wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race where concurrent reply-waiting
intercom({ action: "ask" })tool calls can crash Pi withError: Already waiting for a reply.Root Cause
pi-agent-coremay execute same-turn tool calls concurrently.pi-intercomuses a singlereplyWaiter, so concurrentaskcalls need to fail cleanly before sending.The regular
intercomaskpath checkedreplyWaiterbefore awaitingresolveSessionTarget(...), but did not recheck after that await. A parallel ask can installreplyWaiterduring that window. The later call then reacheswaitForReply(...), receives an already-rejected promise, and did not attach a rejection handler immediately.Changes
replyWaiterafter target resolution and before generating/sending the question.replyPromise.catch(() => undefined)immediately afterwaitForReply(...), matching the safer supervisor-contact path.replyWaiterguard.npm test.Validation
Related issue: #29