[801] Fix HomeToolbar popupTheme in non-night mode #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- materialThemeOverlay doesn't work for AppCompatToolbar - since the style is being set explicitly (activity_home), we can use `android:theme`, and this will be applied as an overlay - the popup menu is already taking `colorSurface` correctly, but not sure why it's not setting the text accordingly. Overriding textColorPrimary to colorOnSurface fixes it, while applying it in a small scope (only to the HomeToolbar's popupTheme) means we won't goof anything else up
pfmaggi
approved these changes
Mar 29, 2020
|
Thanks for the contribution and sorry for the delay reviewing it! |
|
No worries, thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
materialThemeOverlaydoesn't work with AppCompatToolbarandroid:theme, and this will be applied as an overlaycolorSurfacecorrectly, but not sure why it's not setting the text accordingly. Overriding textColorPrimary to colorOnSurface fixes it, while applying it in a small scope (only to the HomeToolbar's popupTheme) means we won't goof anything else up💡 Motivation and Context
Fixes #801 - PopMenu has always white text even when in light mode
💚 How did you test it?
Visually - see screenshots
📝 Checklist
./gradlew spotlessApplybefore submitting the PR🔮 Next steps
Wait for comments
📸 Screenshots / GIFs