Repository navigation
Add image crop - #658
Open
luckydu-henry wants to merge 1 commit into
Open
Add image crop#658luckydu-henry wants to merge 1 commit into
luckydu-henry wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I've been using Clay for UI layout in my own game project, and recently I discovered a frequently encountered area where Clay's support is "quite incomplete."
Clay's current ImageElementConfig and ImageRenderData structures do not store image "cropping" information. This means that when laying out a large number of small icons (such as a row of notification icons), you either have to create a complete image for each icon, or pass atlas data and cropping information through imageData.
The first approach causes a lot of unnecessary bandwidth waste, while the second approach requires manual pointer casting and, more dangerously, requires the lifetime of the cropping information to last through the entire Clay layout cycle. But the cropping information is basically just a Clay_BoundingBox, 4
floats, and having to separately manage the lifetime of such small and plain old data creates a lot of taxing extra work.Therefore, I modified
clay.hby adding aClay_BoundingBox cropfield to bothClay_ImageElementConfigandClay_ImageRenderData, to describe the image's cropping range, so that Clay can support atlases more elegantly, with almost no performance overhead.