Skip to content

Conversation

Ahalya-ni
Copy link
Collaborator

@Ahalya-ni Ahalya-ni commented Sep 17, 2025

Pull Request

🤨 Rationale

This PR cleans up the alarms datasource by updating import statements to use single quotes instead of double quotes. It also moves the AlarmsDataSourceCore file and its test file from the alarms root directory to the query-type-handlers folder, as this file is an abstract class containing methods and properties shared by various query type datasources such as ListAlarmsDataSource, AlarmTrendDataSource, and AlarmsCountDataSource.

👩‍💻 Implementation

  • Updated import statements to use single quotes.
  • Moved AlarmsDataSourceCore and its test file from the root directory to the query-type-handlers folder.
  • Renamed AlarmsDataSourceCore to AlarmsQueryHandlersCore as it better represents what the class actually does - it serves as a core foundation for handling different types of alarm queries (list alarms, alarms count, and alarm trend).
  • Updated casing for DefaultQueries.constants.ts file name to maintain consistency.
  • Removed types.ts file, as the root types were previously deleted when we moved them into a dedicated types folder. The file was mistakenly restored during the latest main merge in the same PR.

🧪 Testing

NA

✅ Checklist

Ahalya-ni and others added 30 commits August 28, 2025 11:32
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Manisha Sivakumar <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
… into users/ahalya/feat/alarms/query-alarms-with-default
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
@Ahalya-ni Ahalya-ni changed the title Users/ahalya/chore/alarms/cleanup chore Sep 17, 2025
@Ahalya-ni Ahalya-ni changed the title chore chore(alarms): Standardize import quotes and reorganize AlarmsDataSourceCore Sep 17, 2025
… into users/ahalya/feat/alarms/query-with-filter
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
@Ahalya-ni Ahalya-ni force-pushed the users/ahalya/chore/alarms/cleanup branch from 8b06633 to 3a0a335 Compare September 17, 2025 11:37
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Base automatically changed from users/ahalya/feat/alarms/query-with-filter to main September 18, 2025 10:50
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Signed-off-by: Ahalya Radhakrishnan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant