Adding hardware configuration to method level instead of class level #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mattjet27
approved these changes
Aug 18, 2025
hcnagaraj-e
approved these changes
Aug 18, 2025
nitamil
approved these changes
Aug 18, 2025
lornazh
approved these changes
Aug 19, 2025
Ashutosh-NI
deleted the
users/Ashutosh-NI/HardwareConfigurationCleanUpForGP3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
For the class
AnalogInputTestsinitially the trait[Trait(nameof(HardwareConfiguration), nameof(HardwareConfiguration.GP3))]was added to the class level (which makes all the method in the class to run on GP3) but later methodsInitializeDAQmxTasks_ReadAnalogSamplesFromOneFilteredChannel_ResultsContainExpectedDataandInitializeDAQmxTasks_ReadAnalogWaveformSamplesFromOneFilteredChannel_ResultsContainExpectedDatawere added, which are only expected to run inLungyuan. Due to this the ATS on GP3 testers are failing.Why should this Pull Request be merged?
Removed the
[Trait(nameof(HardwareConfiguration), nameof(HardwareConfiguration.GP3))]from class level and added it to method levels(to those method which are not having trait to run onLungyuan).What testing has been done?
Ran the ATS, and it succeeded.