Skip to content

feat: Add client for SystemLink results API#82

Merged
priyadarshini-ni merged 25 commits intoni:masterfrom
Madhan-Reddy-ni:users/Peram/niresults/add-results-client
Mar 5, 2025
Merged

feat: Add client for SystemLink results API#82
priyadarshini-ni merged 25 commits intoni:masterfrom
Madhan-Reddy-ni:users/Peram/niresults/add-results-client

Conversation

@Madhan-Reddy-ni
Copy link
Contributor

@Madhan-Reddy-ni Madhan-Reddy-ni commented Nov 7, 2024

TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.

What does this Pull Request accomplish?

This PR adds client methods for all of the nitestmonitor result endpoints as well as testing for these endpoints.

Why should this Pull Request be merged?

This is an enhancement to the existing test monitor client and will enable users to more easily interact with SystemLink test results.

What testing has been done?

Auto testing is included against NI's test tier.

API Swagger Link - Results

@Madhan-Reddy-ni Madhan-Reddy-ni changed the title Users/peram/niresults/add results client feat: Add client for SystemLink results API Nov 7, 2024
@santhoshramaraj santhoshramaraj added the enhancement New feature or request label Nov 8, 2024
@SSSantosh18 SSSantosh18 requested a review from rbell517 February 26, 2025 17:51
@santhoshramaraj
Copy link
Member

santhoshramaraj commented Feb 27, 2025

@SSSantosh18 @priyadarshini-ni @rbell517, when creating the ProductsClient, it was agreed that it is better to avoid the TestMonitorClient concept, as it may not be intuitive to users, as they don't see the TestMonitor anywhere on the SLE webpage. It is better to use separate clients for Products, Results, and Steps for the user to relate to the different pages or hierarchy.

FYI - @adamarnesen

@priyadarshini-ni
Copy link
Contributor

@SSSantosh18 @priyadarshini-ni @rbell517, when creating the ProductsClient, it was agreed that it is better to avoid the TestMonitorClient concept, as it may not be intuitive to users, as they don't see the TestMonitor anywhere on the SLE webpage. It is better to use separate clients for Products, Results, and Steps for the user to relate to the different pages or hierarchy.

FYI - @adamarnesen
Related comment - #82 (comment). Confirmation on this would be helpful to proceed further.

@priyadarshini-ni priyadarshini-ni dismissed santhoshramaraj’s stale review March 5, 2025 08:25

The comments provided have been addressed and also aligned with the reviewer

@priyadarshini-ni priyadarshini-ni merged commit 53f1188 into ni:master Mar 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants