Skip to content

Conversation

rahulr-NI
Copy link
Contributor

@rahulr-NI rahulr-NI commented Sep 11, 2025

- [ ] I've updated CHANGELOG.md if applicable.

- [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

This PR is update the nimi-python repository metadata files with those from NI's private repository.
Below are the changes done.

  • Updated the array_dimension parameter as array_dimensions for multi-dimensional arrays.
  • Code gen changes with respect to above variable names changes.

What testing has been done?

Ensured that tox build is successful and generated changes are intended.

@rahulr-NI rahulr-NI changed the title Multidimensional updates as per az do Multidimensional updates as per AzDo for nirfsg and nifake Sep 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.07%. Comparing base (e6533a3) to head (06a1caa).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2132   +/-   ##
=======================================
  Coverage   89.07%   89.07%           
=======================================
  Files          71       71           
  Lines       18960    18960           
=======================================
  Hits        16889    16889           
  Misses       2071     2071           
Flag Coverage Δ
codegenunittests 84.44% <100.00%> (ø)
nidcpowersystemtests 94.61% <ø> (ø)
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.26% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests 85.52% <ø> (ø)
nifgensystemtests 94.61% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsgsystemtests 75.78% <ø> (ø)
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
build/helper/metadata_add_all.py 81.10% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6533a3...06a1caa. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rahulr-NI rahulr-NI marked this pull request as ready for review September 15, 2025 04:03
@ni-jfitzger
Copy link
Collaborator

Like @marcoskirsch suggested in the other PR, you should use an official export for the metadata.

@rahulr-NI
Copy link
Contributor Author

rahulr-NI commented Sep 16, 2025

Like @marcoskirsch suggested in the other PR, you should use an official export for the metadata.

Sure Jay.. I have two more PR in pipeline to align the APIs in same order we have in AzDo and include a bug fix for get_script_names API.. I will use metadata from exports from CI build as suggested for that PR.

@ni-jfitzger
Copy link
Collaborator

No need to wait on system tests for this change.
There are no changes to the system tests or generated files.

@ni-jfitzger ni-jfitzger merged commit 3432530 into ni:master Sep 23, 2025
43 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants