Skip to content

Conversation

rahulr-NI
Copy link
Contributor

@rahulr-NI rahulr-NI commented Sep 11, 2025

- [ ] I've updated CHANGELOG.md if applicable.

- [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

This PR is update the nimi-python repository metadata files with those from NI's private repository.
Below are the changes done.

  • Replacing "enum_class" key name wtih "class" for enum types, which was included to support IntFlag.
  • Code gen changes with respect to above variable names changes.

What testing has been done?

Ensured that tox build is successful and generated changes are intended.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.08%. Comparing base (4b9434f) to head (e2f4bcb).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2129   +/-   ##
=======================================
  Coverage   89.07%   89.08%           
=======================================
  Files          71       71           
  Lines       18960    18960           
=======================================
+ Hits        16889    16890    +1     
+ Misses       2071     2070    -1     
Flag Coverage Δ
codegenunittests 84.44% <ø> (ø)
nidcpowersystemtests 94.65% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.26% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests 85.52% <100.00%> (ø)
nifgensystemtests 94.61% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsgsystemtests 75.78% <ø> (ø)
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
generated/nifake/nifake/enums.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9434f...e2f4bcb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rahulr-NI rahulr-NI changed the title NiFake and NiRfsg changes as per AzDo Generated Metadata enum updates as per AzDo for nirfsg and nifake Sep 11, 2025
@rahulr-NI rahulr-NI marked this pull request as ready for review September 12, 2025 05:48
@marcoskirsch
Copy link
Member

From description:

to match the files generated from AzDo.

Keep in mind this is a public PR in an Open Source repository. Descriptions should be sensical to people who don't work at NI. Consider:

This PR is update the nimi-python repository metadata files with those from NI's private repository.

@marcoskirsch
Copy link
Member

I've made the change.

@marcoskirsch marcoskirsch merged commit 69f02a3 into ni:master Sep 15, 2025
47 of 49 checks passed
@rahulr-NI
Copy link
Contributor Author

From description:

to match the files generated from AzDo.

Keep in mind this is a public PR in an Open Source repository. Descriptions should be sensical to people who don't work at NI. Consider:

This PR is update the nimi-python repository metadata files with those from NI's private repository.

Thanks for updating Marcos. The change makes sense as this is an Open-Source repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants