Skip to content

Conversation

WengLoon-NI
Copy link
Contributor

@WengLoon-NI WengLoon-NI commented Aug 6, 2025

  • This contribution adheres to CONTRIBUTING.md.
    - [ ] I've updated CHANGELOG.md if applicable.
    - [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

The value of maximum_sequence_length will be updated in the upcoming NI-FGEN release, hence this PR is to update the NI-FGEN system tests to simply verify that maximum_sequence_length >= minimum_sequence_length instead of a specific value. This should be sufficient for an API test.

That driver change is causing our internal nimi-python test events to fail, so we need this update to fix those failures.

What testing has been done?

  • PR build is successful

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.08%. Comparing base (6769299) to head (52c91ab).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2127   +/-   ##
=======================================
  Coverage   89.07%   89.08%           
=======================================
  Files          71       71           
  Lines       18960    18960           
=======================================
+ Hits        16889    16890    +1     
+ Misses       2071     2070    -1     
Flag Coverage Δ
codegenunittests 84.44% <ø> (ø)
nidcpowersystemtests 94.65% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.26% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests 85.52% <ø> (ø)
nifgensystemtests 94.61% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsgsystemtests 75.78% <ø> (ø)
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6769299...52c91ab. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ni-jfitzger ni-jfitzger merged commit 4b9434f into ni:master Aug 6, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants