Skip to content

Conversation

vnktshr21
Copy link
Contributor

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Removes export signal method
  • Adds configure deembedding table array and get deembedding table methods
    • Adds system tests to validate these
    • Both involve their own custom expansions
    • configure deembedding table array needed a fancy function with custom expansion since we need to ensure valid incoming array and also need to pass number of ports parameter to C
    • get deembedding table method needed custom expansion since we use a different method call to get the size to use
  • Fixed a shortened enum name
  • Renamed few repeated capabilities and added few
  • Minor error string fixes

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

System tests succeed on both simulated and real hardware.

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2025

Codecov Report

❌ Patch coverage is 90.47619% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.09%. Comparing base (97dc7b8) to head (d6b3e37).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
generated/nirfsg/nirfsg/session.py 81.13% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2123      +/-   ##
==========================================
+ Coverage   89.08%   89.09%   +0.01%     
==========================================
  Files          71       71              
  Lines       18865    18946      +81     
==========================================
+ Hits        16805    16880      +75     
- Misses       2060     2066       +6     
Flag Coverage Δ
codegenunittests 84.48% <ø> (ø)
nidcpowersystemtests 94.65% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.26% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests 85.52% <ø> (ø)
nifgensystemtests 94.61% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsgsystemtests 75.78% <90.47%> (+0.51%) ⬆️
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
generated/nirfsg/nirfsg/_library.py 69.54% <100.00%> (+0.64%) ⬆️
generated/nirfsg/nirfsg/_library_interpreter.py 65.21% <100.00%> (+1.18%) ⬆️
generated/nirfsg/nirfsg/session.py 89.41% <81.13%> (-0.48%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97dc7b8...d6b3e37. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ni-jfitzger ni-jfitzger merged commit 6ca1890 into ni:master Jul 27, 2025
39 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants