Skip to content

Conversation

@rahulr-NI
Copy link
Contributor

@rahulr-NI rahulr-NI commented Jul 15, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Common changes required for supporting the multi-dimensional numpy arrays of numpy complex type as input and output parameter.
    • Unit tests have been added for checking if data gets passed to library correctly with no memory copy.
  • Similar no memory copy check has been added for 1d numpy array case as well.

What testing has been done?

All Unit tests pass.

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 36.58537% with 26 lines in your changes missing coverage. Please review.

Project coverage is 89.08%. Comparing base (37ea6ef) to head (f3488be).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
generated/nifake/nifake/session.py 5.26% 18 Missing ⚠️
generated/nifgen/nifgen/session.py 50.00% 6 Missing ⚠️
generated/nifake/nifake/_grpc_stub_interpreter.py 50.00% 1 Missing ⚠️
generated/nirfsg/nirfsg/_library_interpreter.py 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2120      +/-   ##
==========================================
+ Coverage   88.99%   89.08%   +0.08%     
==========================================
  Files          71       71              
  Lines       18950    18865      -85     
==========================================
- Hits        16864    16805      -59     
+ Misses       2086     2060      -26     
Flag Coverage Δ
codegenunittests 84.48% <100.00%> (+0.03%) ⬆️
nidcpowersystemtests 94.61% <ø> (ø)
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.26% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests 85.52% <9.52%> (-1.30%) ⬇️
nifgensystemtests 94.61% <50.00%> (-0.25%) ⬇️
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsgsystemtests 75.26% <75.00%> (+0.81%) ⬆️
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
build/helper/metadata_add_all.py 81.10% <100.00%> (+0.17%) ⬆️
generated/nirfsg/nirfsg/session.py 89.88% <ø> (-0.07%) ⬇️
generated/nifake/nifake/_grpc_stub_interpreter.py 83.06% <50.00%> (-0.27%) ⬇️
generated/nirfsg/nirfsg/_library_interpreter.py 64.03% <75.00%> (+1.29%) ⬆️
generated/nifgen/nifgen/session.py 91.77% <50.00%> (-0.68%) ⬇️
generated/nifake/nifake/session.py 77.50% <5.26%> (-2.93%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ea6ef...f3488be. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rahulr-NI rahulr-NI marked this pull request as ready for review July 18, 2025 11:59
@ni-jfitzger ni-jfitzger merged commit 97dc7b8 into ni:master Jul 23, 2025
29 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants