-
Notifications
You must be signed in to change notification settings - Fork 98
Enabling enum flags in APIs #2114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling enum flags in APIs #2114
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2114 +/- ##
==========================================
- Coverage 91.24% 88.99% -2.26%
==========================================
Files 67 71 +4
Lines 16386 18950 +2564
==========================================
+ Hits 14952 16865 +1913
- Misses 1434 2085 +651
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Has there been a discussion of the desired FlagBoundary behavior? The default for IntFlag is Keep, whereas the default for Flag is Strict (which raises an error for unsupported values, before the user can ever pass it to the driver). I would think Strict would be preferred, but maybe your team has a different preference or maybe it's a per-Enum decision? |
This was discussed externally. |
What does this Pull Request accomplish?
Support Enum flags with type ViUInt64
List issues fixed by this Pull Request below, if any.
What testing has been done?
Ensure that there are no failures in tox build.