Skip to content

Conversation

ni-jfitzger
Copy link
Collaborator

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  1. Adds official Python 3.13 support to nimi-python through testing.
    The version of Python used by readthedocs for documentataion generation remains unchanged at 3.11. I prefer to be intentional about changes to the generation of documentation.

  2. Update grpcio, grpcio-tools, protobuf deps for Python 3.13 compatibility and regenerate .pb2 files.

grpcio-tools compatibility for version 1.67.0 (The earliest version witha a 3.13 wheel)

  • grpcio >= grpcio-tools version
  • protobuf >=4.21.6?
    • Not so sure about this. I think it may need to be bumped. The generated pb2 files seem to require protobuf 5.27.2.

List issues fixed by this Pull Request below, if any.

What testing has been done?

PR Checks

@ni-jfitzger ni-jfitzger added this to the nimi-python 1.4.9 milestone Feb 5, 2025
'grpc': [
'grpcio>=1.59.0,<2.0',
'protobuf>=4.21.6,<5.0'
'protobuf>=4.21.6'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this will work. We may need to bump it to 5.27.2, based on the failure to import nifake with protobuf 5.26.1.

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.35%. Comparing base (dd57eae) to head (c08c515).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2077      +/-   ##
==========================================
+ Coverage   91.33%   91.35%   +0.01%     
==========================================
  Files          66       66              
  Lines       16274    16292      +18     
==========================================
+ Hits        14864    14883      +19     
+ Misses       1410     1409       -1     
Flag Coverage Δ
codegenunittests 84.95% <ø> (ø)
nidcpowersystemtests 94.59% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.26% <100.00%> (+0.05%) ⬆️
nidigitalunittests 68.44% <66.66%> (-0.01%) ⬇️
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests 87.24% <ø> (ø)
nifgensystemtests 94.86% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
generated/nidigital/nidigital/_library.py 95.04% <100.00%> (+0.05%) ⬆️
...erated/nidigital/nidigital/_library_interpreter.py 90.37% <100.00%> (+0.07%) ⬆️
generated/nidigital/nidigital/session.py 95.92% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd57eae...c08c515. Read the comment docs.

@ni-jfitzger
Copy link
Collaborator Author

Well this is a very unclean set of commits. I'll need to redo this PR.

@ni-jfitzger ni-jfitzger closed this Feb 5, 2025
@ni-jfitzger ni-jfitzger deleted the add-python-3.13-support branch February 5, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Python 3.13 support and loosen protobuf version constraint

2 participants