-
Notifications
You must be signed in to change notification settings - Fork 98
Add Python 3.13 Support #2077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.13 Support #2077
Conversation
…timing before calling method
'grpc': [ | ||
'grpcio>=1.59.0,<2.0', | ||
'protobuf>=4.21.6,<5.0' | ||
'protobuf>=4.21.6' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this will work. We may need to bump it to 5.27.2, based on the failure to import nifake with protobuf 5.26.1.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2077 +/- ##
==========================================
+ Coverage 91.33% 91.35% +0.01%
==========================================
Files 66 66
Lines 16274 16292 +18
==========================================
+ Hits 14864 14883 +19
+ Misses 1410 1409 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Well this is a very unclean set of commits. I'll need to redo this PR. |
What does this Pull Request accomplish?
Adds official Python 3.13 support to nimi-python through testing.
The version of Python used by readthedocs for documentataion generation remains unchanged at 3.11. I prefer to be intentional about changes to the generation of documentation.
Update grpcio, grpcio-tools, protobuf deps for Python 3.13 compatibility and regenerate .pb2 files.
grpcio-tools compatibility for version 1.67.0 (The earliest version witha a 3.13 wheel)
List issues fixed by this Pull Request below, if any.
What testing has been done?
PR Checks