Fix first_samp_timestamp_val property does not work due to missing method in LibraryInterpreter #857
Conversation
…https://github.com/lau-yeexuan/nidaqmx-python into users/yelau/fix_first_samp_timestamp_val_not_working
…https://github.com/lau-yeexuan/nidaqmx-python into users/yelau/fix_first_samp_timestamp_val_not_working
lau-yeexuan
requested review from
bkeryan,
maxxboehme and
zhindes
as code owners
| # Common editor metadata | ||
| .vscode/ | ||
| .vscode/ | ||
| .vs/ |
There was a problem hiding this comment.
Thanks for this, but do you mind making a separate PR for this?
| "GetStartTrigTrigWhen", | ||
| "GetSyncPulseTimeWhen", | ||
| "GetTimingAttributeExTimestamp", |
There was a problem hiding this comment.
There are a lot of Time Trigger functions being removed at the moment... what makes the timestamps more important than the rest? Aren't all of these worth making public?
There was a problem hiding this comment.
We don't use single-attribute get/set functions in this API. We only use generic get/set functions like GetTimingAttribute{Type}.
There was a problem hiding this comment.
Ah hah! Ok, so just an oversight after we (I?) enabled the time types. Gotcha!
There was a problem hiding this comment.
Actually, I'm unresolving this. Can you update the comment above this, Yee Xuan? We do support Time, now, but we don't need these overly-specific entrypoints.
| @@ -1,3 +1,5 @@ | |||
| from datetime import datetime as std_datime | |||
| "GetStartTrigTrigWhen", | ||
| "GetSyncPulseTimeWhen", | ||
| "GetTimingAttributeExTimestamp", |
There was a problem hiding this comment.
We don't use single-attribute get/set functions in this API. We only use generic get/set functions like GetTimingAttribute{Type}.
| * Adopt ni-python-styleguide for hand-written code. | ||
| * Upgrade to Poetry 2.x and migrate `pyproject.toml` format. | ||
| * Add support for Python 3.14. | ||
| * Add support and tests for GetTimingAttributeTimestamp |
There was a problem hiding this comment.
This is a bugfix so it goes under "resolved issues"
3 participants
This contribution adheres to CONTRIBUTING.md.
I've updated CHANGELOG.md if applicable.
I've added tests applicable for this pull request
What does this Pull Request accomplish?
Exclude GetTimingAttributeTimestamp from interpreter ignored functions. The nidaqmx.Timing.first_samp_timestamp_val now works because LibraryInterpreter contains the get_timing_attribute_timestamp method.
Why should this Pull Request be merged?
Fixes #639
AB#3064756
What testing has been done?
Tests to retrieve first_samp_timestamp_val of simulated 9205.