Skip to content

Update Number of Channel Query In Stream Reader's and Writer's Verify Function #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 13, 2025
Merged

Update Number of Channel Query In Stream Reader's and Writer's Verify Function #852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fff3583
Speed up stream reader verify function
EnYi-ni Oct 8, 2025
ef75e3b
Apply similar modification to writer
EnYi-ni Oct 8, 2025
87c3334
Generate the code
EnYi-ni Oct 10, 2025
6350f83
Update CHANGELOG.md
EnYi-ni Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ All notable changes to this project will be documented in this file.
* [Full changelog: 1.2.0...1.3.0](https://github.com/ni/nidaqmx-python/compare/1.2.0...1.3.0)

* ### Resolved Issues
* ...
* [843: read methods use task.in_stream.channels_to_read, which is slow](https://github.com/ni/nidaqmx-python/issues/843)

* ### Major Changes
* (IN PROGRESS behind "WAVEFORM_SUPPORT" feature toggle) Added support for reading and writing Waveform data.
Expand Down
6 changes: 2 additions & 4 deletions generated/nidaqmx/stream_readers/_channel_reader_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ def _verify_array(self, data, number_of_samples_per_channel, is_many_chan, is_ma
if not self._verify_array_shape:
return

channels_to_read = self._in_stream.channels_to_read
number_of_channels = len(channels_to_read.channel_names)
number_of_channels = self._in_stream.num_chans

array_shape: tuple[int, ...] | None = None
if is_many_chan:
Expand Down Expand Up @@ -100,8 +99,7 @@ def _verify_array_digital_lines(self, data, is_many_chan, is_many_line):
if not self._verify_array_shape:
return

channels_to_read = self._in_stream.channels_to_read
number_of_channels = len(channels_to_read.channel_names)
number_of_channels = self._in_stream.num_chans
number_of_lines = self._in_stream.di_num_booleans_per_chan

array_shape: tuple[int, ...] | None = None
Expand Down
6 changes: 2 additions & 4 deletions generated/nidaqmx/stream_writers/_channel_writer_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,7 @@ def _verify_array(self, data, is_many_chan, is_many_samp):
if not self._verify_array_shape:
return

channels_to_write = self._task.channels
number_of_channels = len(channels_to_write.channel_names)
number_of_channels = self._out_stream.num_chans

expected_num_dimensions = None
if is_many_chan:
Expand Down Expand Up @@ -130,8 +129,7 @@ def _verify_array_digital_lines(self, data, is_many_chan, is_many_line):
if not self._verify_array_shape:
return

channels_to_write = self._task.channels
number_of_channels = len(channels_to_write.channel_names)
number_of_channels = self._out_stream.num_chans
number_of_lines = self._out_stream.do_num_booleans_per_chan

expected_num_dimensions = None
Expand Down
6 changes: 2 additions & 4 deletions src/handwritten/stream_readers/_channel_reader_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ def _verify_array(self, data, number_of_samples_per_channel, is_many_chan, is_ma
if not self._verify_array_shape:
return

channels_to_read = self._in_stream.channels_to_read
number_of_channels = len(channels_to_read.channel_names)
number_of_channels = self._in_stream.num_chans

array_shape: tuple[int, ...] | None = None
if is_many_chan:
Expand Down Expand Up @@ -100,8 +99,7 @@ def _verify_array_digital_lines(self, data, is_many_chan, is_many_line):
if not self._verify_array_shape:
return

channels_to_read = self._in_stream.channels_to_read
number_of_channels = len(channels_to_read.channel_names)
number_of_channels = self._in_stream.num_chans
number_of_lines = self._in_stream.di_num_booleans_per_chan

array_shape: tuple[int, ...] | None = None
Expand Down
6 changes: 2 additions & 4 deletions src/handwritten/stream_writers/_channel_writer_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,7 @@ def _verify_array(self, data, is_many_chan, is_many_samp):
if not self._verify_array_shape:
return

channels_to_write = self._task.channels
number_of_channels = len(channels_to_write.channel_names)
number_of_channels = self._out_stream.num_chans

expected_num_dimensions = None
if is_many_chan:
Expand Down Expand Up @@ -130,8 +129,7 @@ def _verify_array_digital_lines(self, data, is_many_chan, is_many_line):
if not self._verify_array_shape:
return

channels_to_write = self._task.channels
number_of_channels = len(channels_to_write.channel_names)
number_of_channels = self._out_stream.num_chans
number_of_lines = self._out_stream.do_num_booleans_per_chan

expected_num_dimensions = None
Expand Down