Skip to content

Conversation

mikeprosserni
Copy link
Contributor

@mikeprosserni mikeprosserni commented Sep 17, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Add LibraryInterpreter.write_digital_waveform() and LibraryInterpreter._internal_write_digital_waveform()
  • Add DigitalSingleChannelWriter.write_waveform()
  • Add support in Task.write() for DigitalWaveform

Why should this Pull Request be merged?

AB#3271832

What testing has been done?

for DigitalSingleChannelWriter:

test___digital_single_channel_writer___write_waveform_feature_disabled___raises_feature_not_supported_error
test___digital_single_channel_writer___write_waveform_wrong_dtype___raises_argument_error
test___digital_single_channel_writer___write_waveform_single_line___outputs_match_final_values
test___digital_single_channel_writer___write_waveform_single_line_with_auto_start___output_matches_final_value
test___digital_single_channel_writer___write_waveform_single_line_with_non_contiguous_data___outputs_match_final_values
test___digital_single_channel_writer___write_waveform_single_line_signal_count_mismatch___raises_daq_error
test___digital_single_channel_writer___write_waveform_multi_line___outputs_match_final_values
test___digital_single_channel_writer___write_waveform_multi_line_with_auto_start___output_matches_final_value
test___digital_single_channel_writer___write_waveform_multi_line_with_non_contiguous_data___outputs_match_final_values
test___digital_single_channel_writer___write_waveform_multi_line_signal_count_mismatch___raises_daq_error
test___digital_single_channel_writer___write_waveform_port_uint8___outputs_match_final_values
test___digital_single_channel_writer___write_waveform_port_uint32___outputs_match_final_values

for Task:

test___task___write_waveform_feature_disabled___raises_feature_not_supported_error
test___task___write_waveform_wrong_dtype___raises_argument_error
test___task___write_waveform_single_line___outputs_match_final_values
test___task___write_waveform_single_line_with_write___outputs_match_final_values
test___task___write_waveform_single_line_with_auto_start___output_matches_final_value
test___task___write_waveform_single_line_with_non_contiguous_data___outputs_match_final_values
test___task___write_waveform_single_line_signal_count_mismatch___raises_daq_error
test___task___write_waveform_multi_line___outputs_match_final_values
test___task___write_waveform_multi_line_with_write___outputs_match_final_values
test___task___write_waveform_multi_line_with_auto_start___output_matches_final_value
test___task___write_waveform_multi_line_with_non_contiguous_data___outputs_match_final_values
test___task___write_waveform_multi_line_signal_count_mismatch___raises_daq_error
test___task___write_waveform_port_uint8___outputs_match_final_values
test___task___write_waveform_port_uint32___outputs_match_final_values

Copy link
Contributor

github-actions bot commented Sep 17, 2025

Test Results

    38 files  ±  0      38 suites  ±0   1h 0m 48s ⏱️ +2s
 2 835 tests + 84   2 243 ✅ + 7    592 💤 + 77  0 ❌ ±0 
48 968 runs  +854  40 280 ✅ +70  8 688 💤 +784  0 ❌ ±0 

Results for commit 4fb50f1. ± Comparison against base commit acba5ea.

♻️ This comment has been updated with latest results.

@mikeprosserni mikeprosserni marked this pull request as ready for review September 18, 2025 16:11
@mikeprosserni mikeprosserni merged commit d629c76 into master Sep 18, 2025
27 checks passed
@mikeprosserni mikeprosserni deleted the users/mprosser/task-3271832-digital-single-waveform-writer branch September 18, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants