-
Notifications
You must be signed in to change notification settings - Fork 186
Add AnalogMultiChannelWriter.write_waveforms #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mikeprosserni
merged 25 commits into
master
from
users/mprosser/task-3258808-analog-multi-waveform-writer
Sep 16, 2025
Merged
Add AnalogMultiChannelWriter.write_waveforms #834
mikeprosserni
merged 25 commits into
master
from
users/mprosser/task-3258808-analog-multi-waveform-writer
Sep 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logSingleChannelWriter to use it
… tests for scaling and noncontiguous arrays
…-3258808-analog-multi-waveform-writer
…k handling for AnalogWaveform lists
…-3258808-analog-multi-waveform-writer
Test Results 38 files ± 0 38 suites ±0 1h 2m 12s ⏱️ - 1m 58s Results for commit 6b80f72. ± Comparison against base commit bb455d1. This pull request removes 12 and adds 54 tests. Note that renamed tests count towards both.
This pull request removes 12 skipped tests and adds 54 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
zhindes
approved these changes
Sep 15, 2025
bkeryan
requested changes
Sep 15, 2025
bkeryan
approved these changes
Sep 16, 2025
…-3258808-analog-multi-waveform-writer
bkeryan
reviewed
Sep 16, 2025
bkeryan
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated CHANGELOG.md if applicable.What does this Pull Request accomplish?
LibraryInterpreter.write_analog_waveforms()
andLibraryInterpreter._internal_write_analog_waveform_per_chan()
AnalogMultiChannelWriter.write_waveforms()
Task.write()
for lists ofAnalogWaveform
Why should this Pull Request be merged?
AB#3258808
What testing has been done?
for AnalogMutliChannelWriter:
for Task: