Skip to content

Conversation

mikeprosserni
Copy link
Contributor

@mikeprosserni mikeprosserni commented Sep 15, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Add LibraryInterpreter.write_analog_waveforms() and LibraryInterpreter._internal_write_analog_waveform_per_chan()
  • Add AnalogMultiChannelWriter.write_waveforms()
  • Add support in Task.write() for lists of AnalogWaveform

Why should this Pull Request be merged?

AB#3258808

What testing has been done?

for AnalogMutliChannelWriter:

test___analog_multi_channel_writer___write_waveforms_feature_disabled___raises_feature_not_supported_error
test___analog_multi_channel_writer___write_waveforms___output_matches_final_values
test___analog_multi_channel_writer___write_waveforms_with_float32_dtype___output_matches_final_values
test___analog_multi_channel_writer___write_waveforms_with_scaling___output_matches_final_values
test___analog_multi_channel_writer___write_waveforms_with_non_contiguous_data___output_matches_final_values
test___analog_multi_channel_writer___write_waveforms_with_different_lengths___raises_daq_error
test___analog_multi_channel_writer___write_waveforms_with_wrong_number_of_channels___raises_daq_error

for Task:

test___task___write_waveforms_feature_disabled___raises_feature_not_supported_error
test___task___write_waveforms___output_matches_final_values
test___task___write_waveform_as_list___output_matches_final_value
test___task___write_waveform_with_write___output_matches_final_values
test___task___write_waveforms_with_write___output_matches_final_values
test___task___write_waveforms_with_different_formulas___output_matches_final_values
test___task_with_single_channel___write_multiple_waveforms___raises_daq_error
test___task___write_waveform_and_array___raises_value_error
test___task___write_waveforms_with_different_lengths___raises_daq_error
test___task___write_waveforms_with_auto_start___output_matches_final_values
test___task___write_waveforms_with_float32_dtype___output_matches_final_values
test___task___write_waveforms_with_scaling___output_matches_final_values
test___task___write_waveforms_with_non_contiguous_data___output_matches_final_values
test___task___write_waveforms_with_timing___all_samples_match_waveform_data

Copy link
Contributor

github-actions bot commented Sep 15, 2025

Test Results

    38 files  ±  0      38 suites  ±0   1h 2m 12s ⏱️ - 1m 58s
 2 751 tests + 42   2 236 ✅ ±0    515 💤 + 42  0 ❌ ±0 
48 114 runs  +434  40 210 ✅ ±0  7 904 💤 +434  0 ❌ ±0 

Results for commit 6b80f72. ± Comparison against base commit bb455d1.

This pull request removes 12 and adds 54 tests. Note that renamed tests count towards both.
tests.component.stream_writers.test_analog_single_channel_writer ‑ test___analog_single_channel_writer___write_waveform___updates_output[grpc_init_kwargs]
tests.component.stream_writers.test_analog_single_channel_writer ‑ test___analog_single_channel_writer___write_waveform___updates_output[library_init_kwargs]
tests.component.stream_writers.test_analog_single_channel_writer ‑ test___analog_single_channel_writer___write_waveform_with_float32_dtype___updates_output[grpc_init_kwargs]
tests.component.stream_writers.test_analog_single_channel_writer ‑ test___analog_single_channel_writer___write_waveform_with_float32_dtype___updates_output[library_init_kwargs]
tests.component.stream_writers.test_analog_single_channel_writer ‑ test___analog_single_channel_writer___write_waveform_with_non_contiguous_data___updates_output[grpc_init_kwargs]
tests.component.stream_writers.test_analog_single_channel_writer ‑ test___analog_single_channel_writer___write_waveform_with_non_contiguous_data___updates_output[library_init_kwargs]
tests.component.stream_writers.test_analog_single_channel_writer ‑ test___analog_single_channel_writer___write_waveform_with_scaling___updates_output[grpc_init_kwargs]
tests.component.stream_writers.test_analog_single_channel_writer ‑ test___analog_single_channel_writer___write_waveform_with_scaling___updates_output[library_init_kwargs]
tests.component.task.test_task_write_waveform_ao ‑ test___task___write_waveform_with_auto_start___waveform_executes_successfully[grpc_init_kwargs]
tests.component.task.test_task_write_waveform_ao ‑ test___task___write_waveform_with_auto_start___waveform_executes_successfully[library_init_kwargs]
…
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms___output_matches_final_values[grpc_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms___output_matches_final_values[library_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_feature_disabled___raises_feature_not_supported_error[grpc_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_feature_disabled___raises_feature_not_supported_error[library_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_different_lengths___raises_daq_error[grpc_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_different_lengths___raises_daq_error[library_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_float32_dtype___output_matches_final_values[grpc_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_float32_dtype___output_matches_final_values[library_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_non_contiguous_data___output_matches_final_values[grpc_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_non_contiguous_data___output_matches_final_values[library_init_kwargs]
…
This pull request removes 12 skipped tests and adds 54 skipped tests. Note that renamed tests count towards both.
tests.component.stream_writers.test_analog_single_channel_writer ‑ test___analog_single_channel_writer___write_waveform___updates_output[grpc_init_kwargs]
tests.component.stream_writers.test_analog_single_channel_writer ‑ test___analog_single_channel_writer___write_waveform___updates_output[library_init_kwargs]
tests.component.stream_writers.test_analog_single_channel_writer ‑ test___analog_single_channel_writer___write_waveform_with_float32_dtype___updates_output[grpc_init_kwargs]
tests.component.stream_writers.test_analog_single_channel_writer ‑ test___analog_single_channel_writer___write_waveform_with_float32_dtype___updates_output[library_init_kwargs]
tests.component.stream_writers.test_analog_single_channel_writer ‑ test___analog_single_channel_writer___write_waveform_with_non_contiguous_data___updates_output[grpc_init_kwargs]
tests.component.stream_writers.test_analog_single_channel_writer ‑ test___analog_single_channel_writer___write_waveform_with_non_contiguous_data___updates_output[library_init_kwargs]
tests.component.stream_writers.test_analog_single_channel_writer ‑ test___analog_single_channel_writer___write_waveform_with_scaling___updates_output[grpc_init_kwargs]
tests.component.stream_writers.test_analog_single_channel_writer ‑ test___analog_single_channel_writer___write_waveform_with_scaling___updates_output[library_init_kwargs]
tests.component.task.test_task_write_waveform_ao ‑ test___task___write_waveform_with_auto_start___waveform_executes_successfully[grpc_init_kwargs]
tests.component.task.test_task_write_waveform_ao ‑ test___task___write_waveform_with_auto_start___waveform_executes_successfully[library_init_kwargs]
…
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms___output_matches_final_values[grpc_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms___output_matches_final_values[library_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_feature_disabled___raises_feature_not_supported_error[grpc_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_feature_disabled___raises_feature_not_supported_error[library_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_different_lengths___raises_daq_error[grpc_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_different_lengths___raises_daq_error[library_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_float32_dtype___output_matches_final_values[grpc_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_float32_dtype___output_matches_final_values[library_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_non_contiguous_data___output_matches_final_values[grpc_init_kwargs]
tests.component.stream_writers.test_analog_multi_channel_writer ‑ test___analog_multi_channel_writer___write_waveforms_with_non_contiguous_data___output_matches_final_values[library_init_kwargs]
…

♻️ This comment has been updated with latest results.

@mikeprosserni mikeprosserni marked this pull request as ready for review September 15, 2025 18:27
@mikeprosserni mikeprosserni merged commit 1f92791 into master Sep 16, 2025
27 checks passed
@mikeprosserni mikeprosserni deleted the users/mprosser/task-3258808-analog-multi-waveform-writer branch September 16, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants